Fix circuit extending with self#3843
Merged
Merged
Conversation
- patching _append might not catch future implementations where += is done differently - also other tests with timeout already exist - this is cleaner than before
Cryoris
requested review from
1ucian0,
ajavadia,
ewinston,
kdk and
mtreinish
as code owners
kdk
approved these changes
Feb 14, 2020
kdk
added
the
Changelog: Fixed
kdk
previously approved these changes
Feb 14, 2020
Member
kdk
left a comment
kdk
left a comment
There was a problem hiding this comment.
Looks good, can you add a release note?
mtreinish
reviewed
Feb 14, 2020
kdk
approved these changes
Feb 14, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* fix multiple += qc * add test * use timeout as test failure - patching _append might not catch future implementations where += is done differently - also other tests with timeout already exist - this is cleaner than before * remove accidentially tracked file * remove unused import * add reno * test circuit ops after extension Co-authored-by: Kevin Krsulich <kevin@krsulich.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently
qc += qcruns into an infinite-while loop becauseqcis extended via reference. This PR copies the rhs object of+=if it is equal toself.Closes #3811.
Details and comments
The line
qc += qcincludes different possible cases a user might encounter, e.g.A timeout test is added to check that
qc += qcterminates.