Remove quaternions from XYX synthesis algorithm#3628
Merged
Conversation
Start adding infrastructure for phase correct one-qubit synthesis
chriseclectic
force-pushed
the
remove-quaternions
branch
from
2934422 to
fa12111
Compare
ajavadia
reviewed
Dec 19, 2019
ajavadia
approved these changes
Dec 31, 2019
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* Remove quaternions from XYX synthesis algorithm Start adding infrastructure for phase correct one-qubit synthesis * add angles_zxz function Co-authored-by: Ali Javadi-Abhari <ajavadia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start adding infrastructure for phase correct one-qubit synthesis
Summary
Details and comments
Removing the quaternions transformation is necessary for phase correct synthesis for the XYX basis in #3472. This PR makes some other style fixes to the one qubit synthesis class in preparation for the phase-correct synthesis in that PR