Deterministic test_synthesis.py#3586
Merged
mergify[bot] merged 84 commits intoAug 19, 2020
Merged
Conversation
ajavadia
previously requested changes
Dec 11, 2019
Member
ajavadia
left a comment
ajavadia
left a comment
There was a problem hiding this comment.
this needs to be moved to test/randomized. can't just reduce this to testing a small set of inputs as there are many, many numerical corner cases.
…kit-terra into deterministic_test_synthesis
1ucian0
changed the title
1ucian0
changed the title
1ucian0
changed the title
kdk
previously approved these changes
Aug 14, 2020
Co-authored-by: Kevin Krsulich <kevin@krsulich.net>
…kit-terra into deterministic_test_synthesis
Co-authored-by: Kevin Krsulich <kevin@krsulich.net>
…kit-terra into deterministic_test_synthesis
kdk
approved these changes
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my crusade to have more deterministic tests, this PR removes random from
test_synthesis.py