Fix graphviz check in pass manager visualization #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the graphviz check in the pass manager visualization added recently in Qiskit#2445. The check was added to determine if the dot command was in the default PATH by trying to subprocess out and run 'dot -V' however the way in which subprocess was called results in both the dot version string and a blank line being printed if graphviz is actually installed. This happens on import time which we definitely don't want to do (and breaks test discovery in stestr).
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
chriseclectic,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
nonhermitian and
taalexander
as code owners
jaygambetta
approved these changes
May 24, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
This commit fixes the graphviz check in the pass manager visualization added recently in Qiskit#2445. The check was added to determine if the dot command was in the default PATH by trying to subprocess out and run 'dot -V' however the way in which subprocess was called results in both the dot version string and a blank line being printed if graphviz is actually installed. This happens on import time which we definitely don't want to do (and breaks test discovery in stestr).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes the graphviz check in the pass manager visualization
added recently in #2445. The check was added to determine if the dot
command was in the default PATH by trying to subprocess out and run
'dot -V' however the way in which subprocess was called results in both
the dot version string and a blank line being printed if graphviz is
actually installed. This happens on import time which we definitely
don't want to do (and breaks test discovery in stestr). This commit addresses
that by updating the subprocess call to redirect stdout and stderr, but it also
loosens the exception catch to never raise, if anything fails during the attempt
to run dot we should not treat that as fatal, instead just say we don't have
graphviz.
Details and comments