Fix histogram ylimit for multiple executions#1661
Merged
Merged
Conversation
In the plot_histogram function there was a bug when there were multiple executions passed into the function with the y axes bounds. We were previously setting the ylimit for each iteration of loop which goes over each execution. However we should look at the max probability across all executions when determining the upper limit for the yaxis. This commit fixes this change by saving all the probabilities in a list outside the loop and then moving the ax.ylim() to the end of that loop. Fixes: Qiskit#1660
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
nonhermitian and
taalexander
as code owners
jaygambetta
approved these changes
Jan 10, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
In the plot_histogram function there was a bug when there were multiple executions passed into the function with the y axes bounds. We were previously setting the ylimit for each iteration of loop which goes over each execution. However we should look at the max probability across all executions when determining the upper limit for the yaxis. This commit fixes this change by saving all the probabilities in a list outside the loop and then moving the ax.ylim() to the end of that loop. Fixes: Qiskit#1660
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the plot_histogram function there was a bug when there were multiple
executions passed into the function with the y axes bounds. We were
previously setting the ylimit for each iteration of loop which goes over
each execution. However we should look at the max probability across all
executions when determining the upper limit for the yaxis. This commit
fixes this change by saving all the probabilities in a list outside the
loop and then moving the ax.ylim() to the end of that loop.
Details and comments
Fixes: #1660