Remove unnecessary tearDown code#15406
Merged
Merged
Conversation
The `_backends` instance value on `BasicProvider()` is an instance value, so re-calculating it on each test return no longer has any effect. The corresponding value _used_ to be a class attribute on `BasicAer`, but this was changed in Qiskit#11422.
Collaborator
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 19833134767Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mtreinish
approved these changes
Dec 2, 2025
Member
mtreinish
left a comment
There was a problem hiding this comment.
I feel like there was something with the fake providers in the need for this historically too (like the provider list was being modified at runtime by the fake provider listing somewhere. But regardless it seems safe to remove this now.
Member
Author
|
Yeah, when this was the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_backendsinstance value onBasicProvider()is an instance value, so re-calculating it on each test return no longer has any effect. The corresponding value used to be a class attribute onBasicAer, but this was changed in #11422.Summary
Details and comments