Add default line length for jupyter#1400
Merged
Merged
Conversation
When running the text circuit drawer in jupyter the default line length was being setting with the get_terminal_size() call. However this was returning the size of the terminal used to launch jupyter, not the cell size. So this could cause issues if your terminal is much smaller or much larger than the cell size. To fix this issue this commit adds a default of 80 characters for the default line length when running in jupyter so it'll always fit in the cell.
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
nonhermitian and
taalexander
as code owners
Member
|
What about add horizontal scrolling? What do you think @jaygambetta ?
|
1ucian0
reviewed
Dec 3, 2018
Member
1ucian0
left a comment
1ucian0
left a comment
There was a problem hiding this comment.
maybe add this behavior case in the docstring?
Member
|
i am good with what you and @mtreinish decided |
ajavadia
approved these changes
Dec 4, 2018
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
When running the text circuit drawer in jupyter the default line length was being setting with the get_terminal_size() call. However this was returning the size of the terminal used to launch jupyter, not the cell size. So this could cause issues if your terminal is much smaller or much larger than the cell size. To fix this issue this commit adds a default of 80 characters for the default line length when running in jupyter so it'll always fit in the cell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running the text circuit drawer in jupyter the default line length
was being setting with the get_terminal_size() call. However this was
returning the size of the terminal used to launch jupyter, not the cell
size. So this could cause issues if your terminal is much smaller or
much larger than the cell size. To fix this issue this commit adds a
default of 80 characters for the default line length when running in
jupyter so it'll always fit in the cell.
Details and comments