Skip to content

Remove schedule, sequence and related unit tests#13809

Merged
mtreinish merged 5 commits into
Qiskit:mainfrom
ElePT:remove-schedule-sequence
Feb 7, 2025
Merged

Remove schedule, sequence and related unit tests#13809
mtreinish merged 5 commits into
Qiskit:mainfrom
ElePT:remove-schedule-sequence

Conversation

@ElePT
Copy link
Copy Markdown
Contributor

@ElePT ElePT commented Feb 7, 2025

Summary

This PR removes the schedule and sequence functions deprecated in qiskit 1.3 as part of the Pulse deprecation effort.

Details and comments

Part of #13662

@ElePT ElePT requested review from a team, eggerdj, nkanazawa1989 and wshanks as code owners February 7, 2025 14:19
@qiskit-bot
Copy link
Copy Markdown
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @nkanazawa1989

mtreinish
mtreinish previously approved these changes Feb 7, 2025
qubits = [qubit_map[q] for q in node.qargs]
_pass.get_calibration(node.op, qubits)

def test_ecr_cx_forward(self):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests could arguably be kept and be rewritten to assert based on the the pulse gates more directly. But since the pass deprecation is in the merge queue currently I think it's fine to just drop this now.

Copy link
Copy Markdown
Contributor Author

@ElePT ElePT Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test has actually just been removed in main, so problem solved :)

The functions ``sequence`` and ``schedule`` from the :mod:`.compiler`
module have been removed following their deprecation in Qiskit 1.3.
These functions depend on and relate to the Pulse package which is
also being removed in Qiskit 2.0. No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might expand on this a bit more to explain there isn't an alternative to this because it depends on being able to translate circuits to pulse from backend definitions that is not present. But we can do this in the release round-up PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded in c6f1366, but we should probably improve it in the release PR (as most of the removal renos that relate to these large removal epics).

@mtreinish mtreinish enabled auto-merge February 7, 2025 14:26
@ElePT ElePT requested a review from nonhermitian as a code owner February 7, 2025 15:42
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13203145301

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 160 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.2%) to 88.293%

Files with Coverage Reduction New Missed Lines %
qiskit/utils/parallel.py 1 80.7%
crates/accelerate/src/two_qubit_decompose.rs 1 91.99%
qiskit/providers/fake_provider/fake_openpulse_3q.py 1 92.86%
crates/qasm2/src/lex.rs 3 92.23%
qiskit/scheduler/schedule_circuit.py 5 58.82%
qiskit/scheduler/methods/basic.py 38 25.49%
qiskit/scheduler/sequence.py 46 0.0%
qiskit/scheduler/lowering.py 65 20.0%
Totals Coverage Status
Change from base Build 13202126042: -0.2%
Covered Lines: 78634
Relevant Lines: 89060

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Feb 7, 2025
Merged via the queue into Qiskit:main with commit 9ae0a80 Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants