Fix bug in BindingsArray.__getitem__()#11800
Merged
chriseclectic merged 1 commit intoFeb 14, 2024
Merged
Conversation
Collaborator
|
One or more of the the following people are requested to review this:
|
chriseclectic
approved these changes
Feb 14, 2024
mtreinish
added
stable backport potential
Pull Request Test Coverage Report for Build 7906614575Details
💛 - Coveralls |
mergify Bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
(cherry picked from commit d603f83)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical bug in
BindingsArray.__getitem__()that causes this method not to work at all, and adds tests for it.Details and comments
The tests that used to test the behaviour of this function were somehow removed in the process of porting this class into Qiskit from a prototype library. This bug was introduced by #11642.