Add BindingsArray as allowed input type to BindingsArray.coerce()#11645
Merged
t-imamichi merged 1 commit intoQiskit:mainfrom Jan 26, 2024
Merged
Conversation
Collaborator
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7659798891
💛 - Coveralls |
ikkoham
added
the
Changelog: None
ikkoham
approved these changes
Jan 26, 2024
Contributor
ikkoham
left a comment
ikkoham
left a comment
There was a problem hiding this comment.
Thank you for finding and fixing the bug. This feature is not released yet, so change log is none.
t-imamichi
reviewed
Jan 26, 2024
t-imamichi
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows the
BindingsArray.coerce()method to pass-through an input of typeBindingsArray.Details and comments
This PR does not check sequence-like inputs in the tests because that conflicts with #11642. At the very least, we need to see if that PR gets approved.