Restrict version-number output of OpenQASM 3 exporter#11418
Merged
Conversation
The exporter previously claimed to simply be `OPENQASM 3;`, though the OpenQASM project has made it clear that they may include minor versions of the language in the future. This updates the exporter to claim to be version `3.0`, so that it does not falsely imply that it matches syntax of a later version of the language specification.
jakelishman
added
Changelog: Fixed
Collaborator
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7212350808Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
mtreinish
approved these changes
Jan 17, 2024
Member
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
LGTM, given the what openqasm3 specifies should be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The exporter previously claimed to simply be
OPENQASM 3;, though the OpenQASM project has made it clear that they may include minor versions of the language in the future. This updates the exporter to claim to be version3.0, so that it does not falsely imply that it matches syntax of a later version of the language specification.Details and comments
This has a minor logical conflict with #11417; whichever of these two PRs merges second will need to update with respect to the other.