tools/find_depreaction.py should be pending-aware#11401
Merged
Conversation
Collaborator
|
One or more of the the following people are requested to review this:
|
ElePT
reviewed
Dec 12, 2023
Contributor
There was a problem hiding this comment.
Thanks Luciano, I think this is a great addition to the tool. Maybe one comment about the --directory argument, are we expecting deprecations anywhere in this package outside of the qiskit directory? or is this to extend the tool to other packages?
Pull Request Test Coverage Report for Build 8124582560Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Contributor
Eric-Arellano
left a comment
There was a problem hiding this comment.
Overall logic looks good to me. These are style suggestions
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #11184, I'm extending tools/find_depreaction.py to be pending-deprecation aware.
Now you can list just the PendingDeprecationWarnings:
or include in your list the PendingDeprecationWarnings:
The default is to exclude them.