Skip to content

tools/find_depreaction.py should be pending-aware#11401

Merged
1ucian0 merged 5 commits into
Qiskit:mainfrom
1ucian0:tools/find_deprecated/1
Apr 12, 2024
Merged

tools/find_depreaction.py should be pending-aware#11401
1ucian0 merged 5 commits into
Qiskit:mainfrom
1ucian0:tools/find_deprecated/1

Conversation

@1ucian0
Copy link
Copy Markdown
Member

@1ucian0 1ucian0 commented Dec 12, 2023

After #11184, I'm extending tools/find_depreaction.py to be pending-deprecation aware.

Now you can list just the PendingDeprecationWarnings:

$ python ./tools/find_deprecated.py -p only

0.21: Released in June 30, 2022 (wrt last minor release, 16 month old)
 - qiskit/transpiler/passes/scheduling/alap.py:30 (__init__) - PENDING
 - qiskit/transpiler/passes/scheduling/asap.py:36 (__init__) - PENDING
 ...

or include in your list the PendingDeprecationWarnings:

$ python ./tools/find_deprecated.py -p include

0.17: Released in April 01, 2021 (wrt last minor release, 31 month old)
 - qiskit/circuit/bit.py:63 (register)
 - qiskit/circuit/bit.py:86 (index)

0.21: Released in June 30, 2022 (wrt last minor release, 16 month old)
 - qiskit/transpiler/passes/scheduling/alap.py:30 (__init__) - PENDING
 - qiskit/transpiler/passes/scheduling/asap.py:36 (__init__) - PENDING
 - ...

The default is to exclude them.

@1ucian0 1ucian0 requested a review from a team as a code owner December 12, 2023 12:07
@qiskit-bot
Copy link
Copy Markdown
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

Copy link
Copy Markdown
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Luciano, I think this is a great addition to the tool. Maybe one comment about the --directory argument, are we expecting deprecations anywhere in this package outside of the qiskit directory? or is this to extend the tool to other packages?

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 8124582560

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 89.296%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 91.18%
crates/qasm2/src/parse.rs 6 97.15%
qiskit/providers/backend_compat.py 15 85.71%
Totals Coverage Status
Change from base Build 8090123354: -0.01%
Covered Lines: 59121
Relevant Lines: 66208

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall logic looks good to me. These are style suggestions

Comment thread tools/find_deprecated.py Outdated
Comment thread tools/find_deprecated.py
Comment thread tools/find_deprecated.py Outdated
Comment thread tools/find_deprecated.py Outdated
1ucian0 and others added 3 commits February 27, 2024 16:01
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1ucian0 1ucian0 added this pull request to the merge queue Apr 12, 2024
Merged via the queue into Qiskit:main with commit adfcf72 Apr 12, 2024
@sbrandhsn sbrandhsn added the Changelog: None Do not include in the GitHub Release changelog. label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: None Do not include in the GitHub Release changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants