Skip to content

Deprecate qpy loading of old library pulses with complex amp #11257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ElePT merged 2 commits into from
Dec 20, 2023
Merged

Deprecate qpy loading of old library pulses with complex amp #11257

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12bb0ef
Promote to deprecation + add release note.
TsafrirA Nov 15, 2023
5f5a702
Fix
TsafrirA Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions qiskit/qpy/binary_io/schedules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,10 @@ def _read_symbolic_pulse(file_obj, version):

# And warn that this will change in future releases:
warnings.warn(
"Complex amp support for symbolic library pulses will be deprecated. "
"Complex amp support for symbolic library pulses will be deprecated in Qiskit 1.0.0. "
Comment thread
TsafrirA marked this conversation as resolved.
Outdated
"Once deprecated, library pulses loaded from old QPY files (Terra version < 0.23),"
" will be converted automatically to float (amp,angle) representation.",
PendingDeprecationWarning,
DeprecationWarning,
)
class_name = "ScalableSymbolicPulse"

Expand Down
13 changes: 13 additions & 0 deletions releasenotes/notes/deprecate-complex-amp-old-qpy-d3d183e84c395d9c.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
deprecations:
- |
Loading library :class:`~.qiskit.pulse.ScalableSymbolicPulse` objects with
complex ``amp`` parameter from
qpy files of version 5 or lower (Qiskit Terra < 0.23.0) is now deprecated.
Following the deprecation in Qiskit 1.0.0, complex `amp` will be automatically
Comment thread
TsafrirA marked this conversation as resolved.
Outdated
converted to float (`amp`,`angle`). The change applies to the pulses:

* :class:`~.qiskit.pulse.Constant`
* :class:`~.qiskit.pulse.Drag`
* :class:`~.qiskit.pulse.Gaussian`
* :class:`~.qiskit.pulse.GaussianSquare`