Deprecate qpy loading of old library pulses with complex amp

.azure/lint-linux.yml

@@ -26,7 +26,10 @@ jobs:
             -c constraints.txt \
             -r requirements.txt \
             -r requirements-dev.txt \
+            ./qiskit_pkg \
             -e .
+          # Build and install both qiskit and qiskit-terra so that any optionals
+          # depending on `qiskit` will resolve correctly.
         displayName: 'Install dependencies'
         env:
           SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"

.azure/test-linux.yml

@@ -29,6 +29,7 @@ jobs:
       QISKIT_SUPPRESS_PACKAGING_WARNINGS: Y
       PIP_CACHE_DIR: $(Pipeline.Workspace)/.pip
       QISKIT_TEST_CAPTURE_STREAMS: 1
+      HAVE_VISUAL_TESTS_RUN: false
 
     steps:
       - task: UsePythonVersion@0
@@ -70,15 +71,17 @@ jobs:
             # Use stable Rust, rather than MSRV, to spot-check that stable builds properly.
             rustup override set stable
             source test-job/bin/activate
-            python -m pip install -U pip setuptools wheel
-            # Install setuptools-rust for building sdist
-            python -m pip install -U -c constraints.txt setuptools-rust
-            python setup.py sdist
+            python -m pip install -U pip
+            python -m pip install -U build
+            python -m build --sdist .
+            python -m build --sdist qiskit_pkg
             python -m pip install -U \
               -c constraints.txt \
               -r requirements.txt \
               -r requirements-dev.txt \
-              dist/qiskit-terra*.tar.gz
+              dist/qiskit*.tar.gz
+            # Build and install both qiskit and qiskit-terra so that any optionals
+            # depending on `qiskit` will resolve correctly.
           displayName: "Install Terra from sdist"
 
       - ${{ if eq(parameters.installFromSdist, false) }}:
@@ -89,7 +92,10 @@ jobs:
               -c constraints.txt \
               -r requirements.txt \
               -r requirements-dev.txt \
+              ./qiskit_pkg \
               -e .
+            # Build and install both qiskit and qiskit-terra so that any optionals
+            # depending on `qiskit` will resolve correctly.
           displayName: "Install Terra directly"
           env:
             SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
@@ -197,7 +203,9 @@ jobs:
           env:
             SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
 
-        - bash: image_tests/bin/python -m unittest discover -v test/visual
+        - bash: |
+            echo "##vso[task.setvariable variable=HAVE_VISUAL_TESTS_RUN;]true"
+            image_tests/bin/python -m unittest discover -v test/visual
           displayName: 'Run image test'
           env:
             # Needed to suppress a warning in jupyter-core 5.x by eagerly migrating to
@@ -213,7 +221,7 @@ jobs:
             archiveType: tar
             archiveFile: '$(Build.ArtifactStagingDirectory)/visual_test_failures.tar.gz'
             verbose: true
-          condition: failed()
+          condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true'))
 
         - task: ArchiveFiles@2
           displayName: Archive circuit results
@@ -222,7 +230,7 @@ jobs:
             archiveType: tar
             archiveFile: '$(Build.ArtifactStagingDirectory)/circuit_results.tar.gz'
             verbose: true
-          condition: failed()
+          condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true'))
 
         - task: ArchiveFiles@2
           displayName: Archive graph results
@@ -231,7 +239,7 @@ jobs:
             archiveType: tar
             archiveFile: '$(Build.ArtifactStagingDirectory)/graph_results.tar.gz'
             verbose: true
-          condition: failed()
+          condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true'))
 
         - task: PublishBuildArtifacts@1
           displayName: 'Publish image test failure diffs'
@@ -240,4 +248,4 @@ jobs:
             artifactName: 'image_test_failure_img_diffs'
             Parallel: true
             ParallelCount: 8
-          condition: failed()
+          condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true'))

.azure/test-macos.yml

@@ -43,7 +43,10 @@ jobs:
             -c constraints.txt \
             -r requirements.txt \
             -r requirements-dev.txt \
+            ./qiskit_pkg \
             -e .
+            # Build and install both qiskit and qiskit-terra so that any optionals
+            # depending on `qiskit` will resolve correctly.
           pip check
         displayName: 'Install dependencies'
         env:

.azure/test-windows.yml

@@ -42,7 +42,10 @@ jobs:
             -c constraints.txt \
             -r requirements.txt \
             -r requirements-dev.txt \
+            ./qiskit_pkg \
             -e .
+          # Build and install both qiskit and qiskit-terra so that any optionals
+          # depending on `qiskit` will resolve correctly.
           pip check
         displayName: 'Install dependencies'
         env:

.github/workflows/coverage.yml

@@ -42,7 +42,7 @@ jobs:
         run: python -m pip install -c constraints.txt --upgrade pip setuptools wheel
 
       - name: Build and install qiskit-terra
-        run: python -m pip install -c constraints.txt -e .
+        run: python -m pip install -c constraints.txt -e . ./qiskit_pkg
         env:
           CARGO_INCREMENTAL: 0
           RUSTFLAGS: "-Cinstrument-coverage"

.github/workflows/docs_deploy.yml

@@ -217,7 +217,7 @@ jobs:
 
       - name: Deploy translations
         id: ssh_key
-        run: qiskit/tools/deploy_translatable_strings.sh
+        run: qiskit/tools/deploy_translatable_strings.sh "${{ github.workspace }}/deploy"
         env:
           encrypted_deploy_po_branch_key: ${{ secrets.ENCRYPTED_DEPLOY_PO_BRANCH_KEY }}
           encrypted_deploy_po_branch_iv: ${{ secrets.ENCRYPTED_DEPLOY_PO_BRANCH_IV }}

.github/workflows/slow.yml

@@ -19,7 +19,7 @@ jobs:
           python -m pip install -U pip setuptools wheel
           python -m pip install -U -r requirements.txt -c constraints.txt
           python -m pip install -U -r requirements-dev.txt -c constraints.txt
-          python -m pip install -c constraints.txt -e .
+          python -m pip install -c constraints.txt -e . ./qiskit_pkg
           python -m pip install "qiskit-aer" "z3-solver" "cplex" -c constraints.txt
         env:
           SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"

.mergify.yml

@@ -6,4 +6,4 @@ pull_request_rules:
     actions:
       backport:
         branches:
-          - stable/0.25
+          - stable/0.45