Relax CI constraint on numpy<1.25 (backport #11020)#11231
Closed
mergify[bot] wants to merge 1 commit into
Closed
Conversation
The major problem in NumPy 1.25 transpired to be that particular versions of Apple clang (including the one used in Numpy's wheel-build CD pipelines) produced non-deterministic code from new SIMD routines for complex multiplication. This in turn destabilised our `Isometry` decompositions, which caused major correctness problems. As of Numpy 1.26.1 (released 2023-10-14), that SIMD code now decays to the scalar form if the compiler was known to be buggy, which restores the previous behaviour. (cherry picked from commit fb8a69d)
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
github-actions
Bot
added
the
Changelog: None
jakelishman
approved these changes
Nov 10, 2023
Pull Request Test Coverage Report for Build 6828215715
💛 - Coveralls |
Member
|
Closing for now for the same reasons we needed #11232. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #11020 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com