Skip to content

Use final_layout_index in BackendEstimator#11198

Merged
jakelishman merged 1 commit into
Qiskit:mainfrom
ikkoham:primitives/refactor-measurement-pass-manager
Nov 6, 2023
Merged

Use final_layout_index in BackendEstimator#11198
jakelishman merged 1 commit into
Qiskit:mainfrom
ikkoham:primitives/refactor-measurement-pass-manager

Conversation

@ikkoham
Copy link
Copy Markdown
Contributor

@ikkoham ikkoham commented Nov 6, 2023

Summary

Just code refactoring.
I used final_layout_index introduced from 0.45 instead of complex workaround.

Details and comments

@ikkoham ikkoham added Changelog: None Do not include in the GitHub Release changelog. mod: primitives Related to the Primitives module labels Nov 6, 2023
@ikkoham ikkoham requested review from a team and t-imamichi as code owners November 6, 2023 08:44
@qiskit-bot
Copy link
Copy Markdown
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ajavadia
  • @ikkoham
  • @levbishop
  • @t-imamichi

Copy link
Copy Markdown
Member

@t-imamichi t-imamichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6768290700

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 86.945%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.67%
crates/qasm2/src/parse.rs 6 97.6%
Totals Coverage Status
Change from base Build 6751909510: 0.02%
Covered Lines: 74369
Relevant Lines: 85536

💛 - Coveralls

@jakelishman jakelishman enabled auto-merge November 6, 2023 09:08
@jakelishman jakelishman added this pull request to the merge queue Nov 6, 2023
Merged via the queue into Qiskit:main with commit fd8a7df Nov 6, 2023
@ikkoham ikkoham deleted the primitives/refactor-measurement-pass-manager branch November 6, 2023 13:38
matthewscottconroy pushed a commit to matthewscottconroy/qiskit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: None Do not include in the GitHub Release changelog. mod: primitives Related to the Primitives module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants