Upgrade PyO3 to 0.20.0.#11117
Merged
Merged
Conversation
kevinhartman
added
Changelog: None
Collaborator
|
One or more of the the following people are requested to review this:
|
jakelishman
approved these changes
Oct 26, 2023
Member
jakelishman
left a comment
jakelishman
left a comment
There was a problem hiding this comment.
This looks sensible, and I think our compile times will appreciate having only one version of syn in our lock. Which particular features from 0.20 are you after?
Member
|
The build failure is probably unrelated to the PyO3 bump: Matt hit the same failure path in #11115. |
Contributor
Author
@jakelishman I'm keen to start using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version bump of Rust dependency
pyo3to0.20.0.Details and comments
PyO3's changelog: https://github.com/PyO3/pyo3/blob/main/CHANGELOG.md#packaging