Fix lack of alternative for Optimizer in AQC#11099
Merged
Merged
Conversation
ElePT
requested review from
a team,
ShellyGarion and
alexanderivrii
as code owners
Collaborator
|
One or more of the the following people are requested to review this:
|
ElePT
changed the title
Optimizer in AQCOptimizer in AQC
Cryoris
reviewed
Oct 25, 2023
Collaborator
Cryoris
left a comment
Cryoris
left a comment
There was a problem hiding this comment.
Overall LGTM, just some minor comments 🙂
Co-authored-by: Julien Gacon <gaconju@gmail.com>
ElePT
changed the title
Optimizer in AQCOptimizer in AQC
ElePT
changed the title
Optimizer in AQCOptimizer in AQC
ElePT
commented
Oct 25, 2023
| @@ -0,0 +1,21 @@ | |||
| --- | |||
| fixes: | |||
Contributor
Author
There was a problem hiding this comment.
Given that the introduction of the alternative should have happened before, I am considering this a "bugfix", and showing the corresponding release note, but it is a bit of a tricky PR because I could also see it as being a new feature.
mtreinish
added
stable backport potential
mergify Bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Add alternative and deprecation warning * Add deprecation test * Apply Julien's suggestion Co-authored-by: Julien Gacon <gaconju@gmail.com> * Apply suggestions from Julien's code review * Move optimizer setting to init * Fix ddt import * Fix lint * Add reno --------- Co-authored-by: Julien Gacon <gaconju@gmail.com> (cherry picked from commit f0d3937)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Add alternative and deprecation warning * Add deprecation test * Apply Julien's suggestion Co-authored-by: Julien Gacon <gaconju@gmail.com> * Apply suggestions from Julien's code review * Move optimizer setting to init * Fix ddt import * Fix lint * Add reno --------- Co-authored-by: Julien Gacon <gaconju@gmail.com> (cherry picked from commit f0d3937) Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While working on the removal of
qiskit.algorithmsI noticed that the use of theOptimizerclass inAQCdid not have a proper alternative path, nor did it raise a deprecation warning. This got overlooked during the deprecation process last release, and is necessary to be able to remove the use of algorithms for 1.0. This fix introduces an alternative on0.45.0to lay the ground for the future removal.Details and comments
This is PR # 1 of the "Opflow & Algorithms deprecation series", it blocks #11086.