Skip to content

Fixed typo in dagcircuit.py#11077

Merged
mtreinish merged 1 commit into
Qiskit:mainfrom
AniketP04:main
Oct 28, 2023
Merged

Fixed typo in dagcircuit.py#11077
mtreinish merged 1 commit into
Qiskit:mainfrom
AniketP04:main

Conversation

@AniketP04
Copy link
Copy Markdown
Contributor

compatiblity -> compatibility

fulfil -> fulfill

@AniketP04 AniketP04 requested a review from a team as a code owner October 21, 2023 08:15
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Oct 21, 2023
@qiskit-bot
Copy link
Copy Markdown
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6596228135

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 86.891%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 1 91.16%
Totals Coverage Status
Change from base Build 6594932071: 0.004%
Covered Lines: 73868
Relevant Lines: 85012

💛 - Coveralls

Copy link
Copy Markdown
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching and fixing these.

``False``, then the ``input_dag`` is assumed to faithfully implement suitable
conditional logic already. This is ignored for :class:`.ControlFlowOp`\\ s (i.e.
treated as if it is ``False``); replacements of those must already fulfil the same
treated as if it is ``False``); replacements of those must already fulfill the same
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I think the single "l" is more common in UK English, while two "l"s is used in US English. But, we use US English for Qiskit so it's fine to change this just in the interest of consistency even though both are valid.

@mtreinish mtreinish added this pull request to the merge queue Oct 27, 2023
@mtreinish mtreinish removed this pull request from the merge queue due to a manual request Oct 27, 2023
@mtreinish mtreinish added this pull request to the merge queue Oct 27, 2023
Merged via the queue into Qiskit:main with commit e7b5615 Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community PR PRs from contributors that are not 'members' of the Qiskit repo

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants