Fix calling backend.name() for backendV2#11065
Merged
Merged
Conversation
Collaborator
|
One or more of the the following people are requested to review this:
|
mtreinish
added
stable backport potential
Pull Request Test Coverage Report for Build 6594223283
💛 - Coveralls |
mtreinish
reviewed
Oct 20, 2023
Member
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
Overall this LGTM. It's a bad assumption that the QuantumInstance had aer hardcoded as always using backendv1. This should fix it, I just left a small suggestions inline
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
approved these changes
Oct 21, 2023
mergify Bot
pushed a commit
that referenced
this pull request
Oct 21, 2023
* add check for backend version to get backend name * move backend_interface_version * check backend is None before get version * Update qiskit/utils/backend_utils.py Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Update releasenotes/notes/fix_backend_name-e84661707058b529.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit d781dcc)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 21, 2023
* add check for backend version to get backend name * move backend_interface_version * check backend is None before get version * Update qiskit/utils/backend_utils.py Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Update releasenotes/notes/fix_backend_name-e84661707058b529.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit d781dcc) Co-authored-by: Jun Doi <doichan@jp.ibm.com>
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Oct 23, 2023
* add check for backend version to get backend name * move backend_interface_version * check backend is None before get version * Update qiskit/utils/backend_utils.py Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Update releasenotes/notes/fix_backend_name-e84661707058b529.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit d781dcc) Co-authored-by: Jun Doi <doichan@jp.ibm.com> (cherry picked from commit 2f76ef0)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
* add check for backend version to get backend name * move backend_interface_version * check backend is None before get version * Update qiskit/utils/backend_utils.py Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Update releasenotes/notes/fix_backend_name-e84661707058b529.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit d781dcc) Co-authored-by: Jun Doi <doichan@jp.ibm.com> (cherry picked from commit 2f76ef0) Co-authored-by: Jun Doi <doichan@jp.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In utils/backend_utils.py we have to check backend's version if we call name() function for V1 and get property name for V2, but calling name() function without checking version
Details and comments
This issue causes Neko test error in Qiskit Aer if we upgrade backend from V1 to V2 and we can not release Qiskit Aer without this fix.