Update remaining unit tests to use FakeGeneric#10918
Merged
Merged
Conversation
ElePT
changed the title
FakeGeneric
7 tasks
ElePT
changed the title
FakeGenericFakeGeneric
This was referenced Oct 3, 2023
ElePT
requested review from
a team,
eggerdj,
ikkoham,
jyu00,
t-imamichi and
wshanks
as code owners
Collaborator
|
One or more of the the following people are requested to review this:
|
9 tasks
Pull Request Test Coverage Report for Build 7729421822
💛 - Coveralls |
Fix backend estimator test Fix lint, backend estimator test Include missing tests
Initial fix Fix calibrations Fix remaining tests
Contributor
kevinhartman
left a comment
kevinhartman
left a comment
There was a problem hiding this comment.
This looks almost ready. The primary change I'd request is that the coupling maps be placed in their own file 🙂.
Co-authored-by: Kevin Hartman <kevin@hart.mn>
| is actually Schedule for just qubit_0""" | ||
| sched_from_backend = self.backend.instruction_schedule_map.get("measure", [0]) | ||
| expected_sched = Schedule( | ||
| (0, Acquire(1472, AcquireChannel(0), MemorySlot(0))), |
Contributor
There was a problem hiding this comment.
@mtreinish can you take a look at these tests? I don't have enough exposure to pulse scheduling to do a proper review
kevinhartman
approved these changes
Jan 31, 2024
Contributor
kevinhartman
left a comment
kevinhartman
left a comment
There was a problem hiding this comment.
This looks good to me, we can always update the tests further if there are any issues.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(2/4) --> This is the second PR of the
FakeBackends refactoring epic.#10266 introduces the
FakeGenericandGenericTargetclasses. This PR is a follow-up that replaces all uses of V2FakeBackends in unit tests with the newFakeGenericclass.Details and comments
FakeBackendsare handled in: Add generic V1 Fake Backends, replace use in tests #10952Files not covered by this PR that still use fake V2 backends:
Visualization tests will most likely be left for a follow up (joint V1 and V2 changes):
TO-DOs: