adds a wignerfuntion Jupyter notebook to qcvv#51
Conversation
|
@diego-plan9 changes in response to Christopher Wood's suggestions. Are these OK? |
Now works agains updated libraries but not we were unable to confirm against the simulator but not the experiment as the experiments timed out.
|
For reference, this PR is related to the SDK's Qiskit/qiskit#146 and Qiskit/qiskit#132 - in practice, it requires the latest development version of the SDK instead of the stable version, which probably means we should hold off merging until the branch convention changes are in place.
@markjeveritt, can you eventually try with a higher |
jaygambetta
left a comment
There was a problem hiding this comment.
but this one only in master. As it uses unstable versions of the sdk at the moment.
|
@jaygambetta @diego-plan9 @rraymondhp Can confirm that this notebook works in our tests - see it has been merged into master - is there anything else we need to do on this one please? |
|
Hi @markjeveritt |
|
Dear @markjeveritt |
|
@rraymondhp Thank you. I am sorry but I am getting confused now - just when I though I was beginning to understand Git it seems that I was suffering from hubris! I thought I had done this (https://github.com/markjeveritt/qiskit-tutorial/blob/master/index.ipynb) but I now see that they are not listed as commits here. It may seem like I was ignoring your requests - but its just me being dumb - my apologies for talking your time here. I am also really sorry but I can't find where to look to check. Please could you point me in the right direction? |
|
@markjeveritt Sorry for forgetting to tell you my Pull Request. It is as linked here: I am new to Github. Basically, I am asking the admin to pull my |
|
@rraymondhp No problem - so we are learning together! It looks good to me - thank you. |
No description provided.