Skip to content
This repository was archived by the owner on Aug 21, 2023. It is now read-only.

adds a wignerfuntion Jupyter notebook to qcvv#51

Merged
rraymondhp merged 6 commits into
Qiskit:masterfrom
markjeveritt:master
Nov 17, 2017
Merged

adds a wignerfuntion Jupyter notebook to qcvv#51
rraymondhp merged 6 commits into
Qiskit:masterfrom
markjeveritt:master

Conversation

@markjeveritt
Copy link
Copy Markdown

No description provided.

@markjeveritt
Copy link
Copy Markdown
Author

@diego-plan9 changes in response to Christopher Wood's suggestions. Are these OK?

Mark Everitt added 4 commits November 11, 2017 03:37
Now works agains updated libraries but not we were unable to confirm against the simulator but not the experiment as the experiments timed out.
@diego-plan9
Copy link
Copy Markdown
Member

For reference, this PR is related to the SDK's Qiskit/qiskit#146 and Qiskit/qiskit#132 - in practice, it requires the latest development version of the SDK instead of the stable version, which probably means we should hold off merging until the branch convention changes are in place.

We have updated and tested the Jupyter notebook. This now works agains updated libraries but note we were only able to confirm against the simulator but not the experiment as the experiments timed out.

@markjeveritt, can you eventually try with a higher timeout value for the Q_program.execute() calls, and let us know if the plots for the experiments work?

@atilag atilag changed the base branch from master to stable November 15, 2017 15:54
@atilag atilag changed the base branch from stable to master November 15, 2017 15:56
Copy link
Copy Markdown
Member

@jaygambetta jaygambetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this one only in master. As it uses unstable versions of the sdk at the moment.

@rraymondhp rraymondhp merged commit 326c0d6 into Qiskit:master Nov 17, 2017
@markjeveritt
Copy link
Copy Markdown
Author

@jaygambetta @diego-plan9 @rraymondhp Can confirm that this notebook works in our tests - see it has been merged into master - is there anything else we need to do on this one please?

@rraymondhp
Copy link
Copy Markdown
Contributor

Hi @markjeveritt
Yes, we need to add a link from index.ipynb to your new tutorial. Otherwise one cannot find it from the main page. Also, I found that the title has a typo: "Funcitons -> Functions". Can you do the quick revision?

@rraymondhp
Copy link
Copy Markdown
Contributor

Dear @markjeveritt
I have added a link to your tutorial from the index page along with some correction to small typos.
Please feel free to suggest changes/addition.

@markjeveritt
Copy link
Copy Markdown
Author

markjeveritt commented Nov 21, 2017

@rraymondhp Thank you.

I am sorry but I am getting confused now - just when I though I was beginning to understand Git it seems that I was suffering from hubris! I thought I had done this (https://github.com/markjeveritt/qiskit-tutorial/blob/master/index.ipynb) but I now see that they are not listed as commits here. It may seem like I was ignoring your requests - but its just me being dumb - my apologies for talking your time here.

I am also really sorry but I can't find where to look to check. Please could you point me in the right direction?

@rraymondhp
Copy link
Copy Markdown
Contributor

@markjeveritt Sorry for forgetting to tell you my Pull Request. It is as linked here:
#56

I am new to Github. Basically, I am asking the admin to pull my master branch that contains the edition of your tutorial:
https://github.com/rraymondhp/qiskit-tutorial

@markjeveritt
Copy link
Copy Markdown
Author

@rraymondhp No problem - so we are learning together!

It looks good to me - thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants