Skip to content
This repository was archived by the owner on Aug 19, 2023. It is now read-only.

Migrate qiskit-ibmq-provider#1718

Merged
mergify[bot] merged 8 commits into
Qiskit:masterfrom
Guillermo-Mijares-Vilarino:migrate-ibmq-provider
May 12, 2023
Merged

Migrate qiskit-ibmq-provider#1718
mergify[bot] merged 8 commits into
Qiskit:masterfrom
Guillermo-Mijares-Vilarino:migrate-ibmq-provider

Conversation

@Guillermo-Mijares-Vilarino
Copy link
Copy Markdown
Contributor

@Guillermo-Mijares-Vilarino Guillermo-Mijares-Vilarino commented Apr 13, 2023

Summary

This PR continues the migration of the qiskit-ibmq-provider repository documentation to a separate page (Qiskit/qiskit-ibmq-provider#1166), this time from the metapackage side.

Details and comments

  • Remove qiskit-ibmq-provider from the list of API references built by the metapackage.
  • Remove the deprecate_ibmq_provider custom extension (it will no longer be necessary)
  • Update the link to the documentation (the new page will be created by Create new documentation page qiskit-ibmq-provider#1166)
  • Remove the section about installing qiskit-ibmq-provider from the getting started.
  • Remove note about the RuntimeWarning from terra when aer and ibmq-provider are not installed. See Wrap qiskit.Aer and qiskit.IBMQ with lazy loading object qiskit#5619.
  • Didn't touch the reference to the configuration variables QISKIT_IBMQ_PROVIDER_LOG_LEVEL and QISKIT_IBMQ_PROVIDER_LOG_FILE from docs/configuration.rst in case these still exist.

Blocked by Qiskit/qiskit-ibmq-provider#1166

@HuangJunye HuangJunye self-assigned this Apr 18, 2023
@Guillermo-Mijares-Vilarino
Copy link
Copy Markdown
Contributor Author

I believe this is ready to review but still blocked by Qiskit/qiskit-ibmq-provider#1166

Copy link
Copy Markdown
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Guillermo! This looks good.

Copy link
Copy Markdown
Contributor

@HuangJunye HuangJunye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot! We can merge as soon as ibmq has its own documentation page.

@HuangJunye HuangJunye added the on hold Can not fix yet label May 9, 2023
@HuangJunye
Copy link
Copy Markdown
Contributor

On hold until Qiskit/qiskit-ibmq-provider#1166 is merged and ibmq provider's own documentation page goes live.

@Guillermo-Mijares-Vilarino
Copy link
Copy Markdown
Contributor Author

Guillermo-Mijares-Vilarino commented May 12, 2023

Now that Qiskit/qiskit-ibmq-provider#1166 is merged we can remove the on hold label.

@HuangJunye HuangJunye removed the on hold Can not fix yet label May 12, 2023
@HuangJunye HuangJunye added the automerge This PR will automatically merge once its CI has passed label May 12, 2023
@mergify mergify Bot merged commit 1184b30 into Qiskit:master May 12, 2023
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 11, 2023
* Remove ibmq provider API build and deprecation extension

* Update ibmq provider link

* Remove deprecation extension from setup

* Run tox -efmt

* Removed ibmq provider installation from getting started

* Remove note about terra's RuntimeWarning when you don't have aer or ibmq

---------

Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge This PR will automatically merge once its CI has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants