This repository was archived by the owner on Aug 19, 2023. It is now read-only.
Use Terra's FakeBackend in benchmarks#1480
Merged
Merged
Conversation
Originally the benchmark suite created its own fake backends to avoid noise if Terra were to add new snapshots. The current old backends use `BaseBackend` and `BaseJob`, which is the legacy interface that has just been removed from mainline Terra, causing the benchmark suite to fail to import. The three fake backends in use are all either decommissioned machines that will have no further updates, or a dummy machine not based on real hardware (and so should not need to be updated). Since it's unlikely that noise will come into the benchmarks from Terra now, it's suitable just to use the Terra-provided ones.
mtreinish
approved these changes
Apr 21, 2022
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 1, 2023
Originally the benchmark suite created its own fake backends to avoid noise if Terra were to add new snapshots. The current old backends use `BaseBackend` and `BaseJob`, which is the legacy interface that has just been removed from mainline Terra, causing the benchmark suite to fail to import. The three fake backends in use are all either decommissioned machines that will have no further updates, or a dummy machine not based on real hardware (and so should not need to be updated). Since it's unlikely that noise will come into the benchmarks from Terra now, it's suitable just to use the Terra-provided ones.
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
Originally the benchmark suite created its own fake backends to avoid noise if Terra were to add new snapshots. The current old backends use `BaseBackend` and `BaseJob`, which is the legacy interface that has just been removed from mainline Terra, causing the benchmark suite to fail to import. The three fake backends in use are all either decommissioned machines that will have no further updates, or a dummy machine not based on real hardware (and so should not need to be updated). Since it's unlikely that noise will come into the benchmarks from Terra now, it's suitable just to use the Terra-provided ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Originally the benchmark suite created its own fake backends to avoid
noise if Terra were to add new snapshots. The current old backends
use
BaseBackendandBaseJob, which is the legacy interface that hasjust been removed from mainline Terra, causing the benchmark suite to
fail to import.
The three fake backends in use are all either decommissioned machines
that will have no further updates, or a dummy machine not based on real
hardware (and so should not need to be updated). Since it's unlikely
that noise will come into the benchmarks from Terra now, it's suitable
just to use the Terra-provided ones.
Details and comments
Needed to fix the current import failures within the benchmark suite due to Qiskit/qiskit#7886.