Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

Add ESP support to the provider#952

Merged
jyu00 merged 17 commits into
Qiskit:masterfrom
zachschoenfeld33:zas-esp-support
Jun 16, 2021
Merged

Add ESP support to the provider#952
jyu00 merged 17 commits into
Qiskit:masterfrom
zachschoenfeld33:zas-esp-support

Conversation

@zachschoenfeld33
Copy link
Copy Markdown
Contributor

@zachschoenfeld33 zachschoenfeld33 commented Jun 9, 2021

Summary

This PR adds the use_measure_esp keyword to the backend.run() method. Provides support for ESP readout from IBM Quantum Providers.

@zachschoenfeld33
Copy link
Copy Markdown
Contributor Author

@taalexander.

@jyu00 would you mind taking a look at this? I just want to make sure the use_measure_esp parameter is passed through correctly to assemble, which is updated in Qiskit/qiskit#6543

Copy link
Copy Markdown
Contributor

@taalexander taalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of minor issues noted.

Comment thread qiskit/providers/ibmq/accountprovider.py Outdated
Comment thread qiskit/providers/ibmq/ibmqbackend.py Outdated
Copy link
Copy Markdown
Contributor

@taalexander taalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let @jyu00 provide the proper approval.

Copy link
Copy Markdown
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor issues but overall looks good!

Comment thread qiskit/providers/ibmq/ibmqbackend.py Outdated
Comment thread releasenotes/notes/meas-esp-5789e8cc0de39323.yaml Outdated
Comment thread test/ibmq/test_ibmq_job_attributes.py Outdated
@jyu00 jyu00 merged commit 349e369 into Qiskit:master Jun 16, 2021
@jyu00 jyu00 added the Changelog: New Feature Include in the Added section of the changelog label Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Changelog: New Feature Include in the Added section of the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants