Skip to content

Finalize account management functionality#66

Merged
rathishcholarajan merged 8 commits intoQiskit:mainfrom
daka1510:account-mgmt-2
Jan 6, 2022
Merged

Finalize account management functionality#66
rathishcholarajan merged 8 commits intoQiskit:mainfrom
daka1510:account-mgmt-2

Conversation

@daka1510
Copy link
Copy Markdown
Contributor

@daka1510 daka1510 commented Jan 3, 2022

Summary

This PR includes the following

Mainline

  • allow to filter accounts returned from service.saved_accounts (by name, default, auth)
  • added log statements to account storage module
  • updated default account name resolution based on auth type

Tests

  • renamed custom_qiskitrc to temporary_account_config_file
  • renamed get_qiskitrc_contents to get_account_config_contents
  • added dedicated unit tests for AccountManager class

Details and comments

Finalizes account management functionality by filling gaps to meet the acceptance criteria proposed via #58.

@daka1510 daka1510 requested review from jyu00 and rathishcholarajan and removed request for jyu00 January 3, 2022 15:47
Copy link
Copy Markdown
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread qiskit_ibm_runtime/accounts/storage.py Outdated
Comment thread test/test_account.py Outdated
Comment thread test/test_account.py Outdated
Comment thread test/test_account.py Outdated
Comment thread test/test_account.py Outdated
@rathishcholarajan rathishcholarajan merged commit 147a7da into Qiskit:main Jan 6, 2022
@daka1510 daka1510 deleted the account-mgmt-2 branch January 14, 2022 10:45
blakejohnson pushed a commit to blakejohnson/qiskit-ibm-runtime that referenced this pull request May 26, 2023
* Add expval

* catch module not found error

Co-authored-by: JESSIE YU <jessieyu@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants