Skip to content

Update qpy version to terra 0.23.1#577

Merged
kt474 merged 18 commits into
Qiskit:mainfrom
kt474:terra-0.22-qpy
Feb 7, 2023
Merged

Update qpy version to terra 0.23.1#577
kt474 merged 18 commits into
Qiskit:mainfrom
kt474:terra-0.22-qpy

Conversation

@kt474
Copy link
Copy Markdown
Contributor

@kt474 kt474 commented Oct 14, 2022

@jyu00 jyu00 added the on hold label Oct 14, 2022
@jyu00
Copy link
Copy Markdown
Collaborator

jyu00 commented Oct 14, 2022

Let's make sure the server has 0.22 qpy before merging this.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 14, 2022

Pull Request Test Coverage Report for Build 4114740375

  • 24 of 73 (32.88%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 64.323%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/qpy/type_keys.py 1 5 20.0%
qiskit_ibm_runtime/qpy/binary_io/circuits.py 12 18 66.67%
qiskit_ibm_runtime/qpy/binary_io/schedules.py 5 44 11.36%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/qpy/binary_io/circuits.py 2 50.52%
Totals Coverage Status
Change from base Build 4108438807: 0.2%
Covered Lines: 3366
Relevant Lines: 5233

💛 - Coveralls

@jyu00 jyu00 added this to the 0.8.0 milestone Oct 27, 2022
@mtreinish
Copy link
Copy Markdown
Member

You might want to pull in the fixes from 0.22.1 too, there aren't any format changes on the 0.22.x series just bugfixes for edge cases in the circuit.

@kt474 kt474 requested a review from jyu00 November 2, 2022 14:49
@jakelishman
Copy link
Copy Markdown
Member

If we release Terra 0.22.2 today, is that going to cause versioning issues?

@jyu00
Copy link
Copy Markdown
Collaborator

jyu00 commented Nov 3, 2022

If we release Terra 0.22.2 today, is that going to cause versioning issues?

@jakelishman It'll be fine since qiskit-ibm-runtime uses its own copy of qpy now.

@jyu00 jyu00 removed this from the 0.8.0 milestone Nov 3, 2022
@jakelishman
Copy link
Copy Markdown
Member

Just a note: the content of fdaa4e7 is currently tagged for Terra 0.23.0 in late January, rather than the 0.22.3 bugfix release. It's only deserialisation fixes, so it should be safe to include if you want it immediately, but we pushed it from Terra 0.22.3 because we were nervous about the scope of the change.

@kt474 kt474 changed the title Add Terra 0.22.0 qpy updates Update qpy version to terra 0.23.1 Feb 3, 2023
@kt474 kt474 removed the on hold label Feb 5, 2023
@kt474 kt474 added this to the 0.9.0 milestone Feb 6, 2023
@kt474 kt474 merged commit 2b1db68 into Qiskit:main Feb 7, 2023
@kt474 kt474 deleted the terra-0.22-qpy branch August 11, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants