Add input data check for Sampler#519
Conversation
07fa5bf to
0a182f3
Compare
0a182f3 to
73748fb
Compare
Pull Request Test Coverage Report for Build 2977882163
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3091977741
💛 - Coveralls |
Cryoris
left a comment
There was a problem hiding this comment.
Two small comments, otherwise LGTM!
Cryoris
left a comment
There was a problem hiding this comment.
LGTM! For the Terra primitives we can essentially apply the same update, right?
|
Yeah, I will port this change to Terra next week. |
6acccb4 to
1fe373c
Compare
|
I updated this PR and made the same checks to terra Qiskit/qiskit#8678. |
# Conflicts: # qiskit_ibm_runtime/sampler.py
|
I removed the validation check whether there is any classical bits not measured. |
# Conflicts: # qiskit_ibm_runtime/sampler.py
|
Note that this check exists in Terra main branch's |
We will use terra's |
|
Yes, it's hard to sync with primitives in terra because it has been actively updated. Maybe copying a snapshot sometimes is a compromise. |
Summary
Add a validation check of circuits for Sampler. It raises an error if there is no classical bits in the input circuits.
I added the same test to Terra Qiskit/qiskit#8678 Qiskit/qiskit#8708
So, if we use the base class of primitives of Terra, we can remove these checks in qiskit-ibm-runtime.
Details and comments