Skip to content

Fix broken if conditions in setup_test_logging #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rathishcholarajan merged 1 commit into from
Dec 7, 2021
+2 −2
Merged

Fix broken if conditions in setup_test_logging #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ def setup_test_logging(logger: logging.Logger, filename: str):
)
formatter = logging.Formatter(log_fmt)

if os.getenv("STREAM_LOG", "true"):
if os.getenv("STREAM_LOG", "true").lower() == "true":
Comment thread
rathishcholarajan marked this conversation as resolved.
# Set up the stream handler.
stream_handler = logging.StreamHandler()
stream_handler.setFormatter(formatter)
logger.addHandler(stream_handler)

if os.getenv("FILE_LOG", "false"):
if os.getenv("FILE_LOG", "false").lower() == "true":
Comment thread
rathishcholarajan marked this conversation as resolved.
file_handler = logging.FileHandler(filename)
file_handler.setFormatter(formatter)
logger.addHandler(file_handler)
Expand Down