Skip to content

Remove unused backend code#38

Merged
rathishcholarajan merged 2 commits intoQiskit:mainfrom
jyu00:more-cleanup
Nov 30, 2021
Merged

Remove unused backend code#38
rathishcholarajan merged 2 commits intoQiskit:mainfrom
jyu00:more-cleanup

Conversation

@jyu00
Copy link
Copy Markdown
Collaborator

@jyu00 jyu00 commented Nov 29, 2021

Summary

Some more cleanup

  • Remove apiconstants.py, which is only used for the legacy job path (with the exception of QISKIT_IBM_RUNTIME_API_URL, which is moved to constants.py)
  • Remove backendjoblimit.py since runtime doesn't have job limits
  • Raise an error in backend.run()
  • Remove _deprecate_id_instruction() because it's only used in backend.run().

We may need to remove backend reservation as well since it's not supported by cloud runtime and isn't really related to runtime.

Details and comments

Fixes #

Copy link
Copy Markdown
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @jyu00!

@rathishcholarajan rathishcholarajan self-requested a review November 30, 2021 10:57
Copy link
Copy Markdown
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyu00 Looks good. Could you please fix lint?

@daka1510
Copy link
Copy Markdown
Contributor

FYI: I've hit the same linting error in my other PR and fixed it already via ac4f27c.

************* Module qiskit_ibm_runtime.runtime_program
qiskit_ibm_runtime/runtime_program.py:17:0: W0611: Unused List imported from typing (unused-import)

Neither Jessie, nor I have touched qiskit_ibm_runtime/runtime_program so I'm not sure why the unused import wasn't caught earlier.

@rathishcholarajan given the above and that we're in an early stage of this repo: do you think we can go ahead and integrate this refactoring and trust that the linter issue will be fixed with my PR in a next step :)?

@rathishcholarajan
Copy link
Copy Markdown
Member

FYI: I've hit the same linting error in my other PR and fixed it already via ac4f27c.

************* Module qiskit_ibm_runtime.runtime_program
qiskit_ibm_runtime/runtime_program.py:17:0: W0611: Unused List imported from typing (unused-import)

Neither Jessie, nor I have touched qiskit_ibm_runtime/runtime_program so I'm not sure why the unused import wasn't caught earlier.

@rathishcholarajan given the above and that we're in an early stage of this repo: do you think we can go ahead and integrate this refactoring and trust that the linter issue will be fixed with my PR in a next step :)?

Thanks @daka1510! That is weird. We need to investigate if this happens again.

@rathishcholarajan rathishcholarajan merged commit 9f8b89e into Qiskit:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants