Poll status API after stream closes in wait_for_final_state until it is final#341
Merged
rathishcholarajan merged 2 commits intoQiskit:mainfrom May 27, 2022
Merged
Conversation
Pull Request Test Coverage Report for Build 2397135270
💛 - Coveralls |
kt474
approved these changes
May 27, 2022
Contributor
kt474
left a comment
kt474
left a comment
There was a problem hiding this comment.
LGTM as a short term fix
But I believe the point of the original PR was to remove polling - so it would be nice if there was a server side solution
rathishcholarajan
added
the
Changelog: Bugfix
blakejohnson
pushed a commit
to blakejohnson/qiskit-ibm-runtime
that referenced
this pull request
May 26, 2023
* fix primiitives that use mthree 2.0 Additionlly, it supports mid-circuit measurements thanks to mthree 2.0 * enable mid-circuit measurements for sampler * fix seed_mitigation of TREX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait_for_final_state used to poll for status every x seconds.
This poll logic was a bit heavy on the server and hence PR #33 used the end of the results websocket stream to figure the end of the job, but there is a delay between when the stream closes and the status is updated in the db. So if status is queried in between that time it returns running. So as a short term fix until this is fixed on server side, we can poll for status after stream closes and until it is final.
Details and comments
Fixes #311
Also fixes this intermittent integration test failure due to this https://github.com/Qiskit/qiskit-ibm-runtime/runs/6585776699?check_suite_focus=true#step:5:1795