Warn when finalize_options() overrides a property explicitly set by the user - #3182
Open
TsafrirA wants to merge 3 commits into
Open
Warn when finalize_options() overrides a property explicitly set by the user#3182TsafrirA wants to merge 3 commits into
finalize_options() overrides a property explicitly set by the user#3182TsafrirA wants to merge 3 commits into
Conversation
Collaborator
Author
|
@SamFerracin estimator = EstimatorV2(backend)
estimator.options.resilience.pec_mitigation = True
estimator.options.twirling.enable_gates = FalseThe job runs and the metadata shows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a warning when
finalize_options()overrides a field which was explicitly set by the user. It uses the recent transition to pydantic models which allow the distinction between defaults and values explicitly set by the user.AI/LLM disclosure