-
Notifications
You must be signed in to change notification settings - Fork 213
Deprecate auth parameter and add new channel parameter #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rathishcholarajan
merged 31 commits into
Qiskit:main
from
rathishcholarajan:217-channel-parameter
Mar 29, 2022
Merged
Changes from 20 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
558749c
Add channel parameter
rathishcholarajan 7c8380c
Fix unit tests
rathishcholarajan fadb457
Add mising space
rathishcholarajan b6d1f80
Save account with new channel parameter even when auth is passed
rathishcholarajan c503154
Fix delete_account for auth parameter
rathishcholarajan 0ada0c9
Fix style
rathishcholarajan 4417689
Make auth parameter work with saved_accounts
rathishcholarajan 8edfdc9
Support auth parameter when enabling account
rathishcholarajan 77bb29c
Merge branch 'main' into 217-channel-parameter
rathishcholarajan c94531f
Merge branch 'main' into 217-channel-parameter
rathishcholarajan b9c16c7
Revert temporarily to fix doc builds on fork
rathishcholarajan 99073f7
Add some tests for overwriting saved auth accounts with channel accounts
rathishcholarajan bc79b25
Add couple more scenarios for testing overwriting named auth accounts…
rathishcholarajan 0922e28
Add couple more tests for saving named legacy accounts
rathishcholarajan 20a27a7
Test to list existing auth accounts in channel format
rathishcholarajan 1db9e99
Fix lint
rathishcholarajan 44a21e8
Add test for filtering auth accounts
rathishcholarajan 4513d55
Fix lint
rathishcholarajan 648647b
Fix failing integration tests
rathishcholarajan bfbd3da
Add tests for deleting existing auth accounts using channel
rathishcholarajan 544b39a
Remove channel IDs to address confusion
rathishcholarajan 593bb82
Update docs/tutorials/04_account_management.ipynb
rathishcholarajan 489409b
Refactor and add functions for duplicated logic
rathishcholarajan dc1288c
Use strings for now since enums don't play well with literals
rathishcholarajan 3d6b2b2
Ban latest released click version to temp fix make style build
rathishcholarajan e6c778e
Add update account function
rathishcholarajan 7b96727
Update black
rathishcholarajan 2ec5f48
Fix docs build
rathishcholarajan 92e7ec2
Merge branch 'main' into 217-channel-parameter
rathishcholarajan 16a46cf
Call migrate function to update config file automatically vs have the…
rathishcholarajan 7d8ee74
Add release note
rathishcholarajan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1 @@ | ||
| .. release-notes:: Release Notes | ||
| :version: 0.2.0, 0.1.0, 0.1.0rc2, 0.1.0rc1 | ||
|
rathishcholarajan marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.