Enable automated code coverage reports via coveralls.io#144
Merged
Conversation
daka1510
commented
Feb 9, 2022
daka1510
commented
Feb 9, 2022
| path: htmlcov | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| flag-name: unit-tests_python${{ matrix.python-version }}-${{ matrix.os }} | ||
| parallel: true |
Contributor
Author
There was a problem hiding this comment.
Given that our coverage differs based on environment, test type and potentially other factors I like the ability to report coverage metrics for all jobs in a single run.
Shows up in Coveralls like below
daka1510
requested review from
kdk,
kt474 and
rathishcholarajan
and removed request for
kdk
rathishcholarajan
approved these changes
Feb 15, 2022
Member
rathishcholarajan
left a comment
rathishcholarajan
left a comment
There was a problem hiding this comment.
LGTM! Left a minor suggestion, can be merged after addressing that...
blakejohnson
pushed a commit
to blakejohnson/qiskit-ibm-runtime
that referenced
this pull request
May 26, 2023
Add primitive tag to programs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable Coveralls integration. See below links for details.
Inspired by other open source Qiskit libraries that already integrate with Coveralls (https://coveralls.io/github/Qiskit)
Details and comments
Partially solves #22. We should discuss adding a code coverage badge to the README once this PR is integrated to fully solve it.