Skip to content

Enable disabled pylint rules pt.1 #133

Merged
rathishcholarajan merged 7 commits into
Qiskit:mainfrom
kt474:pylint-rules-part-1
Jan 31, 2022
Merged

Enable disabled pylint rules pt.1 #133
rathishcholarajan merged 7 commits into
Qiskit:mainfrom
kt474:pylint-rules-part-1

Conversation

@kt474
Copy link
Copy Markdown
Contributor

@kt474 kt474 commented Jan 28, 2022

Summary

Enabling the disabled pylint rules that had little/no effect. Each remaining rule that needs to be enabled will be in a separate PR.

Enabled/Fixed:
consider-iterating-dictionary
consider-using-dict-items
f-string-without-interpolation
missing-type-doc
redundant-returns-doc
use-dict-literal
use-list-literal
differing-param-doc

Details and comments

Fixes part of #42

@kt474 kt474 changed the title Enable disabled pylint rules pt.1 [WIP] Enable disabled pylint rules pt.1 Jan 28, 2022
@kt474 kt474 changed the title [WIP] Enable disabled pylint rules pt.1 Enable disabled pylint rules pt.1 Jan 31, 2022
@kt474
Copy link
Copy Markdown
Contributor Author

kt474 commented Jan 31, 2022

Remaining rules that need to be fixed or stay disabled

arguments-renamed
bad-mcs-classmethod-argument
consider-using-f-string
consider-using-with
docstring-first-line-empty
invalid-name:
missing-param-doc
no-member
raise-missing-from
super-with-arguments
unspecified-encoding

Copy link
Copy Markdown
Contributor

@daka1510 daka1510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, looks good to me.

Copy link
Copy Markdown
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rathishcholarajan rathishcholarajan merged commit f955414 into Qiskit:main Jan 31, 2022
@kt474 kt474 deleted the pylint-rules-part-1 branch January 31, 2022 14:52
blakejohnson pushed a commit to blakejohnson/qiskit-ibm-runtime that referenced this pull request May 26, 2023
…ord/1

hello-world program return "Hello, World!"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants