Unite Session from qiskit_ibm_provider with Session in this repository#1280
Closed
merav-aharoni wants to merge 24 commits intoQiskit:mainfrom
Closed
Unite Session from qiskit_ibm_provider with Session in this repository#1280merav-aharoni wants to merge 24 commits intoQiskit:mainfrom
Session from qiskit_ibm_provider with Session in this repository#1280merav-aharoni wants to merge 24 commits intoQiskit:mainfrom
Conversation
Pull Request Test Coverage Report for Build 7749509110
💛 - Coveralls |
…runtime into unite_sessions
kt474
reviewed
Dec 20, 2023
Contributor
|
With the upcoming deprecation of backend.run() I will close this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IBMBackend.run()now uses the sameSessionas used by the primitives.Details and comments
I made changes in the imports because of cyclic imports.
IBMBackendcan receive a Session in 3 ways:IBMBackend.run(). This makes more sense than setting it in__init__, because often the user will define the backend asbackend = service.get_backend(), so the backend will keep the sameSessionobject even if the session is closed, causing failures. Even if we callbackend = service.get_backend()again, backend will still be the same object as before.IBMBackend.open_session(). I believe this should eventually be deprecated.