Change default Cloud URL#118
Merged
rathishcholarajan merged 5 commits intoJan 24, 2022
Merged
Conversation
daka1510
changed the title
daka1510
commented
Jan 24, 2022
Comment on lines
+55
to
+59
| ( | ||
| "crn:v1:bluemix:public:quantum-computing:us-east:a/...:...::", | ||
| "https://cloud.ibm.com", | ||
| "https://us-east.quantum-computing.cloud.ibm.com", | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
I manually verified that it also works for the tuple
("crn:v1:staging:public:quantum-computing:us-east:a/f80115697ee84cd4aa15dd3c795e9445:5cd72baf-d1a4-4434-996b-8a45c0123efb::", "https://test.cloud.ibm.com", "https://us-east.quantum-computing.test.cloud.ibm.com")
Based on feedback on a previous PR where you were against adding explicit support in code for our staging environments, I concluded it might be better to leave it out from the test case here.
daka1510
requested review from
jyu00 and
rathishcholarajan
and removed request for
rathishcholarajan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change URL format provided by users
Background: we do not want to introduce breaking changes after the first release. The URL supplied by the user should allow to infer the Runtime API Base URL and resource controller API (and potentially others).
Details and comments
Fixes #116
Prerequisites
QISKIT_IBM_CLOUD_URLto be reconfigured tohttps://(test.)cloud.ibm.com