Skip to content

Exceptions should inherit from Terra where suitable #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kt474 merged 3 commits into from
Oct 3, 2023
Merged

Exceptions should inherit from Terra where suitable #1120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
500727e
Changed RuntimeJobFailureError to inherit from JobError
merav-aharoni Oct 1, 2023
381e7bc
Changed error type
merav-aharoni Oct 1, 2023
12322af
Merge branch 'main' into exceptions
kt474 Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions qiskit_ibm_runtime/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"""Exceptions related to the IBM Runtime service."""

from qiskit.exceptions import QiskitError
from qiskit.providers.exceptions import JobTimeoutError
from qiskit.providers.exceptions import JobTimeoutError, JobError


class IBMError(QiskitError):
Expand Down Expand Up @@ -70,7 +70,7 @@ class RuntimeProgramNotFound(IBMRuntimeError):
pass


class RuntimeJobFailureError(IBMRuntimeError):
class RuntimeJobFailureError(JobError):
"""Error raised when a runtime job failed."""

pass
Expand Down
4 changes: 3 additions & 1 deletion test/unit/mock/fake_runtime_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
from concurrent.futures import ThreadPoolExecutor
from typing import Optional, Dict, Any, List

from qiskit.providers.exceptions import QiskitBackendNotFoundError

from qiskit_ibm_provider.utils.hgp import from_instance_format
from qiskit_ibm_runtime.api.exceptions import RequestsApiError
from qiskit_ibm_runtime.utils import RuntimeEncoder
Expand Down Expand Up @@ -543,4 +545,4 @@ def _find_backend(self, backend_name):
for back in self._backends:
if back.name == backend_name:
return back
raise ValueError(f"Backend {backend_name} not found")
raise QiskitBackendNotFoundError(f"Backend {backend_name} not found")