Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Update tox configuration to support tox 3.x and 4.x#469

Merged
kt474 merged 1 commit into
Qiskit:mainfrom
mtreinish:fix-tox-config
Dec 12, 2022
Merged

Update tox configuration to support tox 3.x and 4.x#469
kt474 merged 1 commit into
Qiskit:mainfrom
mtreinish:fix-tox-config

Conversation

@mtreinish
Copy link
Copy Markdown
Member

Summary

This commit updates the tox configuration to remove the sdist configuration flag which avoids the intermediate sdist creation as part of tox building the package under test in it's venv. It is replaced by the isolated_build option which configures tox to use a PEP 518/PEP 517 mechanism for building experiments. This mirrors the default behavior in tox 4.0.0. By making this change the tox.ini should be compatible with both tox 3.x.y and 4.x.y.

Details and comments

This commit updates the tox configuration to remove the sdist
configuration flag which avoids the intermediate sdist creation as
part of tox building the package under test in it's venv. It is replaced
by the isolated_build option which configures tox to use a PEP 518/PEP
517 mechanism for building experiments. This mirrors the default
behavior in tox 4.0.0. By making this change the tox.ini should be
compatible with both tox 3.x.y and 4.x.y.
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3658672516

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.149%

Totals Coverage Status
Change from base Build 3640842877: 0.0%
Covered Lines: 2865
Relevant Lines: 5713

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt474 kt474 merged commit d085790 into Qiskit:main Dec 12, 2022
@kt474 kt474 added this to the 0.2.0 milestone Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants