Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Add support for building Targets with control flow operations#406

Merged
kt474 merged 3 commits into
Qiskit:mainfrom
mtreinish:control-flow-target-construction
Oct 18, 2022
Merged

Add support for building Targets with control flow operations#406
kt474 merged 3 commits into
Qiskit:mainfrom
mtreinish:control-flow-target-construction

Conversation

@mtreinish
Copy link
Copy Markdown
Member

Summary

In Qiskit/qiskit#8852 support is being added to the Target class for representing globally available variable width operations in order to support control flow operations. This will be included in the 0.22.0 release. When IBM backends start listing that they support control flow operations we need to be constructing the Target for the backend with the control flow operations. This commit adds the necessary handling so that when a backend lists the control flow operations in the configuration payload we add the instructions correctly to the Target.

Details and comments

This is blocked on qiskit-terra 0.22.0 being released. Once the release is live we'll have to update the minimum version in the requirements list and then we can move forward on this PR.

In Qiskit/qiskit#8852 support is being added to the Target class
for representing globally available variable width operations in order
to support control flow operations. This will be included in the 0.22.0
release. When IBM backends start listing that they support control flow
operations we need to be constructing the Target for the backend with
the control flow operations. This commit adds the necessary handling so
that when a backend lists the control flow operations in the
configuration payload we add the instructions correctly to the Target.
@mtreinish mtreinish added the on hold Cannot fix yet label Oct 11, 2022
@mtreinish mtreinish added this to the 0.0.1 milestone Oct 11, 2022
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3229042291

  • -4 of 5 (20.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 35.182%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/utils/backend_converter.py 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_provider/utils/backend_converter.py 1 14.15%
Totals Coverage Status
Change from base Build 3201538096: 0.2%
Covered Lines: 2690
Relevant Lines: 7646

💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 11, 2022

Pull Request Test Coverage Report for Build 3267217773

  • 1 of 5 (20.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 38.5%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/utils/backend_converter.py 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_provider/utils/backend_converter.py 1 14.15%
Totals Coverage Status
Change from base Build 3246837894: 0.2%
Covered Lines: 2690
Relevant Lines: 6987

💛 - Coveralls

@mtreinish mtreinish added Changelog: New Feature Include in the Added section of the changelog and removed on hold Cannot fix yet labels Oct 13, 2022
Copy link
Copy Markdown
Contributor

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt474 kt474 merged commit dca308d into Qiskit:main Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Changelog: New Feature Include in the Added section of the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants