Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Migrate from "auth" to "channel" parameter#311

Merged
rathishcholarajan merged 2 commits into
Qiskit:mainfrom
daka1510:268_remove-auth
Mar 31, 2022
Merged

Migrate from "auth" to "channel" parameter#311
rathishcholarajan merged 2 commits into
Qiskit:mainfrom
daka1510:268_remove-auth

Conversation

@daka1510
Copy link
Copy Markdown
Collaborator

@daka1510 daka1510 commented Mar 31, 2022

Summary

Removed support for "auth" parameter, added support for "channel" parameter. Based on Qiskit/qiskit-ibm-runtime#226. Unlike qiskit-ibm-runtime, qiskit-ibm-provider does not expose the auth or channel parameter to the user via public APIs because only a single channel (ibm_quantum) is supported. As a result, this change is transparent for users. The migration code is still needed because qiskit-ibm.json is shared with qiskit-ibm-runtime and may include the old auth-based format

Details and comments

#268

@daka1510 daka1510 changed the title fix: migrate from "auth" to "channel" parameter Migrate from "auth" to "channel" parameter Mar 31, 2022
@daka1510
Copy link
Copy Markdown
Collaborator Author

@rathishcholarajan can you add new environments ("ibm-quantum-production", "ibm-quantum-staging") with the known secrets?

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 31, 2022

Pull Request Test Coverage Report for Build 2071219523

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 57 of 68 (83.82%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 36.066%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/accounts/account.py 12 13 92.31%
qiskit_ibm_provider/api/auth.py 1 2 50.0%
qiskit_ibm_provider/api/clients/auth.py 1 2 50.0%
qiskit_ibm_provider/ibm_provider.py 3 4 75.0%
qiskit_ibm_provider/accounts/management.py 36 43 83.72%
Totals Coverage Status
Change from base Build 2071215039: 0.3%
Covered Lines: 1804
Relevant Lines: 5002

💛 - Coveralls

Copy link
Copy Markdown
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rathishcholarajan
Copy link
Copy Markdown
Member

@rathishcholarajan can you add new environments ("ibm-quantum-production", "ibm-quantum-staging") with the known secrets?

Done

@rathishcholarajan rathishcholarajan merged commit 7aeef38 into Qiskit:main Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants