This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Remove IBMRuntimeService related code#243
Merged
rathishcholarajan merged 5 commits intoQiskit:mainfrom Mar 1, 2022
Merged
Conversation
|
|
rathishcholarajan
suggested changes
Mar 1, 2022
Member
rathishcholarajan
left a comment
rathishcholarajan
left a comment
There was a problem hiding this comment.
@daka1510 Could you please resolve merge conflicts (I merged other open PRs)?
# Conflicts: # qiskit_ibm/ibm_provider.py # qiskit_ibm/runtime/ibm_runtime_service.py # test/ibm/runtime/test_runtime.py # test/ibm/runtime/test_runtime_integration.py
Collaborator
Author
|
Resolved conflicts, please take a look. Yesterday, all CI checks in this PR passed (https://github.com/Qiskit/qiskit-ibm-provider/actions/runs/1910894234). But after a few other PRs have been integrated into main the unit tests no longer work. Let's fix them via dedicated efforts. |
# Conflicts: # docs/apidocs/ibm-provider.rst # qiskit_ibm/ibm_provider.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove code related to
IBMRuntimeServicebecause it's part of https://github.com/qiskit/qiskit-ibm-runtime now.Details and comments
Solves #232
Approach
qiskit_ibm/runtimeIBMRuntimeService, also deleted code fragments that relied on deleted code