Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Remove experiment service#241

Merged
rathishcholarajan merged 10 commits intoQiskit:mainfrom
kt474:remove-experiments
Mar 1, 2022
Merged

Remove experiment service#241
rathishcholarajan merged 10 commits intoQiskit:mainfrom
kt474:remove-experiments

Conversation

@kt474
Copy link
Copy Markdown
Contributor

@kt474 kt474 commented Feb 17, 2022

Summary

Fixes #233

Details and comments

@kt474 kt474 changed the title [WIP] remove experiment service Remove experiment service Feb 25, 2022
@daka1510
Copy link
Copy Markdown
Collaborator

daka1510 commented Feb 28, 2022

@kt474 some unit tests are now failing, see https://github.com/Qiskit/qiskit-ibm-provider/runs/5313592939?check_suite_focus=true

@daka1510
Copy link
Copy Markdown
Collaborator

daka1510 commented Feb 28, 2022 •
edited
Loading

Not sure if those failures are related to your changes and which policy we want to use during the migration. Should CI checks continue to pass, @rathishcholarajan, or do we accept failures as we rework this repository?

My take: let's try to keep our fast CI checks (style, mypy, unit tests) green and make the integration tests work afterwards.

@rathishcholarajan
Copy link
Copy Markdown
Member

rathishcholarajan commented Mar 1, 2022 •
edited
Loading

Not sure if those failures are related to your changes and which policy we want to use during the migration. Should CI checks continue to pass, @rathishcholarajan, or do we accept failures as we rework this repository?

My take: let's try to keep our fast CI checks (style, mypy, unit tests) green and make the integration tests work afterwards.

Yes we can fix test failures after cleanup. I've merged most open PRs and closed some.

rathishcholarajan
rathishcholarajan suggested changes Mar 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kt474 Could you please resolve merge conflicts (I merged other open PRs)?

daka1510
daka1510 reviewed Mar 1, 2022
View reviewed changes
Comment thread qiskit_ibm/ibm_provider.py
Comment on lines 37 to 39
from .hub_group_project import HubGroupProject # pylint: disable=cyclic-import
from .ibm_backend_service import IBMBackendService # pylint: disable=cyclic-import
from .random.ibm_random_service import IBMRandomService # pylint: disable=cyclic-import
Copy link
Copy Markdown
Collaborator

@daka1510 daka1510 Mar 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kt474 Consider removing

qiskit-ibm-provider/qiskit_ibm/ibm_provider.py

Line 89 in 85e6bee

`provider.experiment.create_experiment()`, etc.
as well.

@daka1510 daka1510 mentioned this pull request Mar 1, 2022
Merged
rathishcholarajan
rathishcholarajan approved these changes Mar 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rathishcholarajan rathishcholarajan merged commit 766b060 into Qiskit:main Mar 1, 2022
@kt474 kt474 deleted the remove-experiments branch March 1, 2022 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@rathishcholarajan rathishcholarajan rathishcholarajan approved these changes

@daka1510 daka1510 daka1510 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove experiment service from qiskit-ibm-provider

3 participants

@kt474 @daka1510 @rathishcholarajan