Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Query programs by name #194

Closed
kt474 wants to merge 58 commits intoQiskit:mainfrom
kt474:program-name-query
Closed

Query programs by name #194
kt474 wants to merge 58 commits intoQiskit:mainfrom
kt474:program-name-query

Conversation

@kt474
Copy link
Copy Markdown
Contributor

@kt474 kt474 commented Nov 2, 2021 •
edited
Loading

Summary

fixes #180

Details and comments

There will be merge conflicts and many edits necessary with #170 - should hold off until it is merged first

rathishcholarajan and others added 30 commits October 18, 2021 01:14
@rathishcholarajan
Remove version field from runtime program (Qiskit#152)
464192f 
* Remove version field from runtime program

* Add release note
@rathishcholarajan
Rename isPublic to is_public when creating or reading runtime programs (
abb98d0 
Qiskit#155)
@renier @jyu00
Update programId to program_id when running program (Qiskit#139)
31fdd4b 
This needs to change in the program upload body request in order to
meet the IBM Cloud API guidance.

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
@rathishcholarajan
Add support to view program update date (Qiskit#160)
0d5ebf8
@rathishcholarajan
Upload runtime program using 'data' field (Qiskit#157)
767afeb
@rathishcholarajan
Read programs from "programs" array in response (Qiskit#161)
24dfa95
@rathishcholarajan
Remove version field from runtime program (Qiskit#152)
79cd9bd 
* Remove version field from runtime program

* Add release note
@rathishcholarajan
Rename isPublic to is_public when creating or reading runtime programs (
45ab0b2 
Qiskit#155)
@renier @jyu00 @rathishcholarajan
Update programId to program_id when running program (Qiskit#139)
faff4e2 
This needs to change in the program upload body request in order to
meet the IBM Cloud API guidance.

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
@rathishcholarajan
Add support to view program update date (Qiskit#160)
bcc27fb
@rathishcholarajan
Upload runtime program using 'data' field (Qiskit#157)
866d045
@rathishcholarajan
Read programs from "programs" array in response (Qiskit#161)
eda2a51
@rathishcholarajan
Pass program as base64 string to update (Qiskit#168)
ab33b52
@rathishcholarajan @jyu00
Accept JSON schema as program metadata (Qiskit#158)
a8fe605 
* Accept JSON schema as program metadata

* Update qiskit_ibm/runtime/ibm_runtime_service.py

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
@kt474
Merge branch 'runtime-release-q4' of https://github.com/Qiskit-Partne…
1b26e0b 
…rs/qiskit-ibm into runtime-release-q4
@rathishcholarajan
Pass program params as object (Qiskit#171)
df4eb81
@rathishcholarajan
Fix integration tests
e3e4315
@kt474
Merge branch 'runtime-release-q4' of https://github.com/Qiskit-Partne…
f5712bc 
…rs/qiskit-ibm into runtime-release-q4
@rathishcholarajan
Use count to reduce one last extra call to API (Qiskit#172)
0f95825
@jyu00 @rathishcholarajan
Allow updating runtime metadata in place (Qiskit#188)
b532b14 
* update runtime metadata

* return if no data

* fix mypy

* Update releasenotes/notes/update-runtime-metadata-d2ddbcfc0d034530.yaml

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
@kt474
Merge branch 'runtime-release-q4' of https://github.com/Qiskit-Partne…
c1065f0 
…rs/qiskit-ibm into runtime-release-q4
@rathishcholarajan
Remove version field from runtime program (Qiskit#152)
f5b4e54 
* Remove version field from runtime program

* Add release note
@rathishcholarajan
Rename isPublic to is_public when creating or reading runtime programs (
93a2b85 
Qiskit#155)
@renier @jyu00 @rathishcholarajan
Update programId to program_id when running program (Qiskit#139)
966d42a 
This needs to change in the program upload body request in order to
meet the IBM Cloud API guidance.

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
@rathishcholarajan
Add support to view program update date (Qiskit#160)
031fc25
@rathishcholarajan
Upload runtime program using 'data' field (Qiskit#157)
1561a9b
@rathishcholarajan
Read programs from "programs" array in response (Qiskit#161)
b656ece
@rathishcholarajan
Pass program as base64 string to update (Qiskit#168)
8fb3669
@rathishcholarajan @jyu00
Accept JSON schema as program metadata (Qiskit#158)
74472c5 
* Accept JSON schema as program metadata

* Update qiskit_ibm/runtime/ibm_runtime_service.py

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
@rathishcholarajan
Pass program params as object (Qiskit#171)
ee76158
rathishcholarajan
rathishcholarajan reviewed Nov 5, 2021
View reviewed changes
Comment thread releasenotes/notes/query-program-name-823e8e7cfef44f50.yaml Outdated
@kt474 @rathishcholarajan
Update releasenotes/notes/query-program-name-823e8e7cfef44f50.yaml
4b48ec0 
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
rathishcholarajan
rathishcholarajan suggested changes Nov 5, 2021
View reviewed changes
Comment thread test/ibm/runtime/test_runtime.py Outdated
Comment thread test/ibm/runtime/test_runtime.py Outdated
Comment thread test/ibm/runtime/test_runtime_integration.py Outdated
Comment thread test/ibm/runtime/test_runtime_integration.py Outdated
Comment thread test/ibm/runtime/test_runtime_integration.py Outdated
Comment thread test/ibm/runtime/test_runtime.py Outdated
kt474 and others added 6 commits November 5, 2021 12:27
@kt474 @rathishcholarajan
Update test/ibm/runtime/test_runtime.py
87a5429 
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
@kt474 @rathishcholarajan
Update test/ibm/runtime/test_runtime.py
1d6e8ff 
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
@kt474 @rathishcholarajan
Update test/ibm/runtime/test_runtime_integration.py
005a5d4 
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
@kt474 @rathishcholarajan
Update test/ibm/runtime/test_runtime_integration.py
15655ec 
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
@kt474 @rathishcholarajan
Update test/ibm/runtime/test_runtime_integration.py
35a9879 
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
@kt474 @rathishcholarajan
Update test/ibm/runtime/test_runtime.py
8b01221 
Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
kt474 and others added 2 commits November 7, 2021 19:57
@kt474 @rathishcholarajan
Allow filtering runtime jobs by provider (Qiskit#197)
8133076 
* add provider param

* split provider into hub/group/project

* add reno

* wip add test case

* fix lint/docs

* Update qiskit_ibm/runtime/ibm_runtime_service.py

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* Update releasenotes/notes/filter-jobs-by-provider-dead04faaf223840.yaml

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* refactor test cases

* remove print

* add integration test

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
@rathishcholarajan
Merge branch 'runtime-release-q4' into program-name-query
bbcf7b5
rathishcholarajan
rathishcholarajan reviewed Nov 8, 2021
View reviewed changes
Comment thread qiskit_ibm/api/rest/runtime.py Outdated
rathishcholarajan and others added 2 commits November 7, 2021 21:36
@rathishcholarajan
Update qiskit_ibm/api/rest/runtime.py
7f474e9
@kt474 @rathishcholarajan
Support pagination for retrieving runtime programs (Qiskit#170)
4522d9b 
* wip add limit/offset params

* add reno

* refactor & update test case

* offset -> skip, implement refresh logic

* refresh when skip/limit not default

* Update releasenotes/notes/runtime-program-pagination-8d599ae984a5ce33.yaml

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* Update releasenotes/notes/runtime-program-pagination-8d599ae984a5ce33.yaml

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* add  to test case

* refactor refresh logic

* refactor

* fix lint

* add integration test

* update doc string

* Update qiskit_ibm/api/clients/runtime.py

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* cleanup merge

* Apply suggestions from code review

* fix lint refactor

* Fetch all programs upfront 20 at a time and store in cache

For subsequent requests paginate and return from cache

* Fix integration test

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
Co-authored-by: Rathish Cholarajan <Rathish.C@ibm.com>
@rathishcholarajan
Copy link
Copy Markdown
Member

rathishcholarajan commented Nov 8, 2021

@kt474 If name is passed and we have programs in cache, then we need to loop through programs in cache and return program for given name. If refresh = True is passed then we need to fetch the latest program for given name from API, update cache and then return program.

@rathishcholarajan rathishcholarajan changed the base branch from runtime-release-q4 to main November 9, 2021 22:20
rathishcholarajan
rathishcholarajan suggested changes Nov 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kt474 I had to merge the runtime-release-q4 branch to main. I changed the base of this PR to main. Could you pls rebase with main and resolve conflicts?

@kt474 kt474 mentioned this pull request Nov 17, 2021
Closed
@rathishcholarajan
Copy link
Copy Markdown
Member

rathishcholarajan commented Nov 22, 2021

Moved to Qiskit/qiskit-ibm-runtime#14

@kt474 kt474 mentioned this pull request Jan 7, 2022
Closed
@kt474 kt474 deleted the program-name-query branch April 21, 2022 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rathishcholarajan rathishcholarajan rathishcholarajan requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport potential The bug might be minimal and/or important enough to be port to stable Changelog: New Feature Include in the Added section of the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Query programs by program name

4 participants

@kt474 @rathishcholarajan @renier @jyu00