Handle complex numbers in pulse defaults#694
Closed
mtreinish wants to merge 1 commit into
Closed
Conversation
In Qiskit/qiskit#4016 the pulse defaults (as well as backend configuration and properties) were updated to not rely on marshmallow. A side effect of this change is that the return from to_dict() on pulse defaults no longer will convert complex -> [real, imag] since this is typically an unecessary conversion that complicates using the output. However, the pulse system model class was not handling this as expected and will fail trying to access the the components from [real, imag]. This commit updates this to handle the case when a complex number is passed in.
This was referenced Apr 14, 2020
Member
|
I believe this was included in #695 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Qiskit/qiskit#4016 the pulse defaults (as well as backend
configuration and properties) were updated to not rely on marshmallow. A
side effect of this change is that the return from to_dict() on pulse
defaults no longer will convert complex -> [real, imag] since this is
typically an unecessary conversion that complicates using the output.
However, the pulse system model class was not handling this as expected
and will fail trying to access the the components from [real, imag].
This commit updates this to handle the case when a complex number is
passed in.
Details and comments
This will be blocked until Qiskit/qiskit#4124 merges.