Skip to content

Add backwards compatibility for terra < 0.13#686

Merged
chriseclectic merged 2 commits into
Qiskit:masterfrom
chriseclectic:fix/compatibility-terra-12
Apr 9, 2020
Merged

Add backwards compatibility for terra < 0.13#686
chriseclectic merged 2 commits into
Qiskit:masterfrom
chriseclectic:fix/compatibility-terra-12

Conversation

@chriseclectic
Copy link
Copy Markdown
Member

Summary

Fixes some import issues for updating tests to remove deprecation warnings for 0.13, by allowing backwards compatibility with terra 0.12.

Details and comments

@chriseclectic chriseclectic requested a review from atilag as a code owner April 9, 2020 17:44
mtreinish
mtreinish previously approved these changes Apr 9, 2020
Copy link
Copy Markdown
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, heh although monkey patching the monkey patched methods for testing backwards compat is fun.

@chriseclectic chriseclectic merged commit 17c3b10 into Qiskit:master Apr 9, 2020
mtreinish added a commit to mtreinish/qiskit-aer that referenced this pull request Apr 9, 2020
* Add backwards compatibility for terra < 0.13

* Exclude broken cmake releases

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit 17c3b10)
hhorii pushed a commit to hhorii/qiskit-aer that referenced this pull request Apr 16, 2020
* Add backwards compatibility for terra < 0.13

* Exclude broken cmake releases

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@chriseclectic chriseclectic deleted the fix/compatibility-terra-12 branch April 28, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants