Fix device=Thrust was very slow for small number of qubits#1497
Closed
doichanj wants to merge 1 commit into
Closed
Fix device=Thrust was very slow for small number of qubits#1497doichanj wants to merge 1 commit into
doichanj wants to merge 1 commit into
Conversation
hhorii
approved these changes
Apr 5, 2022
hhorii
added
the
stable-backport-potential
Collaborator
hhorii
pushed a commit
that referenced
this pull request
Apr 6, 2022
Starting with the recently released qiskit-terra 0.20.0 qiskit only builds packages on manylinux2014 now. This commit update the wheel jobs for Aer to install the rust compiler and build terra from source when CI uses manylinux2010 for i686 builds. In manylinux2014 for i686, binary of OpenBLAS is not available and its installation from source codes is necessary. Installation of rust compiler and terra is a lot less effort than compiling OpenBLAS. See the details in #1498. * Thread control for Thrust CPU is now same as device=CPU This commit also includes #1497, which fix performance issue in device=Thrust. A cause of this issue is that Thrust CPU always applied OpenMP for threading kernel programs without referring to the number of qubits. This fix applies OpenMP referring to statevector_parallel_threshold parameter as same as device=CPU. See the details in #1497. Co-authored-by: Jun Doi <doichan@jp.ibm.com>
Collaborator
|
This PR was included in #1498. |
hhorii
pushed a commit
to hhorii/qiskit-aer
that referenced
this pull request
Apr 6, 2022
Starting with the recently released qiskit-terra 0.20.0 qiskit only builds packages on manylinux2014 now. This commit update the wheel jobs for Aer to install the rust compiler and build terra from source when CI uses manylinux2010 for i686 builds. In manylinux2014 for i686, binary of OpenBLAS is not available and its installation from source codes is necessary. Installation of rust compiler and terra is a lot less effort than compiling OpenBLAS. See the details in Qiskit#1498. * Thread control for Thrust CPU is now same as device=CPU This commit also includes Qiskit#1497, which fix performance issue in device=Thrust. A cause of this issue is that Thrust CPU always applied OpenMP for threading kernel programs without referring to the number of qubits. This fix applies OpenMP referring to statevector_parallel_threshold parameter as same as device=CPU. See the details in Qiskit#1497. Co-authored-by: Jun Doi <doichan@jp.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a fix for device=Thrust, Thrust running on CPU was very slow for small number of qubits.
Details and comments
This was because Thrust CPU always applied OpenMP for threading kernel programs without referring to the number of qubits.
This fix applies OpenMP referring to statevector_parallel_threshold parameter as same as device=CPU.