Fix for the latest cuStateVec APIs#1489
Merged
Merged
Conversation
hhorii
reviewed
Mar 24, 2022
|
|
||
| #include "custatevec.h" | ||
|
|
||
| #define SUPPORTS_MEMORY_POOL ( __CUDACC_VER_MAJOR__ > 11 || (__CUDACC_VER_MAJOR__ == 11 && __CUDACC_VER_MINOR__ >= 2)) |
Collaborator
There was a problem hiding this comment.
Can we always use memory pool if it provides performance in any simulation? The latest cuQuantum changed its API (such as custatevecSamplerCreate) and the current cuStateVec_chunk_container.hpp does not support previous API (custatevecSampler_create). I guess, if the current code is based on the latest API, memory pool is always available.
Collaborator
Author
There was a problem hiding this comment.
I removed codes for older version of CUDA and now 11.2 or newer version is required to use cuStateVec support (added in CONTRIBUTING.md)
I think sampling does not support memory pool (https://docs.nvidia.com/cuda/cuquantum/custatevec/api/functions.html#sampling)
so work buffer should be allocated if needed.
hhorii
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the fix to support the latest cuQuantum (ver. 0.40).
Details and comments
Compilation failed with cuStateVec support because some cuStateVec APIs' name and parameters are changed from the previous version. This PR follows the latest cuStateVec.
Also cuQuantum 0.40 newly supports memory pool mechanism to allocate work space inside cuStateVec APIs.
Qiskit Aer now use memory pool instead of allocating static work buffer if the version of CUDA installed on the system supports it.