Split out gpu Python 3.10 wheel build#1472
Merged
Merged
Conversation
The aer gpu package wheel job for python 3.10 builds in the manylinux2014 container image, while for the older Python versions it uses the manylinux2010 image. The manylinux2014 image is based on Centos 7 while the manylinux2010 image is based on Centos 6. During the qiskit-aer 0.10.3 release the gpu wheel job failed because when running the py3.10 build we installed the cuda package for centos 6 in the manylinux2014 centos 7 based image. This caused the job to fail when nvcc was called because it was not installed properly. To fix this issue the Python 3.10 build is split out into a separate job. This separate job will install the same cuda version but for centos 7 which is appropriate for the manylinux2014 image.
mtreinish
added
the
stable-backport-potential
jakelishman
approved these changes
Mar 2, 2022
Member
jakelishman
left a comment
jakelishman
left a comment
There was a problem hiding this comment.
This looks fine to me. There's a Windows-specific build step in these jobs that run on ubuntu-latest which is funny, but not an issue at all.
| env: | ||
| CIBW_BEFORE_ALL: "yum install -y yum-utils wget && wget https://developer.download.nvidia.com/compute/cuda/10.1/Prod/local_installers/cuda-repo-rhel6-10-1-local-10.1.243-418.87.00-1.0-1.x86_64.rpm && rpm -i cuda-repo-rhel6-10-1-local-10.1.243-418.87.00-1.0-1.x86_64.rpm && yum clean all && yum -y install cuda-10-1 openblas-devel" | ||
| CIBW_SKIP: "*-manylinux_i686 pp* cp36* *musllinux*" | ||
| CIBW_BEFORE_ALL: "yum install -y yum-utils wget && wget -q https://developer.download.nvidia.com/compute/cuda/10.1/Prod/local_installers/cuda-repo-rhel6-10-1-local-10.1.243-418.87.00-1.0-1.x86_64.rpm && rpm -i cuda-repo-rhel6-10-1-local-10.1.243-418.87.00-1.0-1.x86_64.rpm && yum clean all && yum -y install cuda-10-1 openblas-devel" |
Member
There was a problem hiding this comment.
Surprised you need to yum install wget - is curl not available and preconfigured in the manylinux images?
(This doesn't need changing or for you to look up if you don't immediately know, I'm just curious if you happen to know off the top of your head, since a quick search didn't turn anything up.)
Member
Author
There was a problem hiding this comment.
Yeah, curl is probably installed in the base image. I think when I originally wrote the job I just used wget because it's what the nvidia install docs used.
hhorii
pushed a commit
to hhorii/qiskit-aer
that referenced
this pull request
Mar 14, 2022
The aer gpu package wheel job for python 3.10 builds in the manylinux2014 container image, while for the older Python versions it uses the manylinux2010 image. The manylinux2014 image is based on Centos 7 while the manylinux2010 image is based on Centos 6. During the qiskit-aer 0.10.3 release the gpu wheel job failed because when running the py3.10 build we installed the cuda package for centos 6 in the manylinux2014 centos 7 based image. This caused the job to fail when nvcc was called because it was not installed properly. To fix this issue the Python 3.10 build is split out into a separate job. This separate job will install the same cuda version but for centos 7 which is appropriate for the manylinux2014 image.
hhorii
pushed a commit
to hhorii/qiskit-aer
that referenced
this pull request
Mar 14, 2022
The aer gpu package wheel job for python 3.10 builds in the manylinux2014 container image, while for the older Python versions it uses the manylinux2010 image. The manylinux2014 image is based on Centos 7 while the manylinux2010 image is based on Centos 6. During the qiskit-aer 0.10.3 release the gpu wheel job failed because when running the py3.10 build we installed the cuda package for centos 6 in the manylinux2014 centos 7 based image. This caused the job to fail when nvcc was called because it was not installed properly. To fix this issue the Python 3.10 build is split out into a separate job. This separate job will install the same cuda version but for centos 7 which is appropriate for the manylinux2014 image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The aer gpu package wheel job for python 3.10 builds in the manylinux2014
container image, while for the older Python versions it uses the
manylinux2010 image. The manylinux2014 image is based on Centos 7 while
the manylinux2010 image is based on Centos 6. During the qiskit-aer
0.10.3 release the gpu wheel job failed because when running the py3.10
build we installed the cuda package for centos 6 in the manylinux2014
centos 7 based image. This caused the job to fail when nvcc was called
because it was not installed properly. To fix this issue the Python 3.10
build is split out into a separate job. This separate job will install
the same cuda version but for centos 7 which is appropriate for the
manylinux2014 image.
Details and comments