Change to truncate T2 up to 2 * T1 in NoiseModel.from_backend#1467
Merged
Conversation
itoko
added
the
Changelog: API Change
Collaborator
|
This needs a test case at least. |
chriseclectic
added
Changelog: Bugfix
Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com>
hhorii
reviewed
Mar 1, 2022
hhorii
added
the
stable-backport-potential
hhorii
added a commit
to hhorii/qiskit-aer
that referenced
this pull request
Mar 14, 2022
…#1467) * Change not to fail to run noisy simulation with T2 > 2 * T1 Previously NoiseModel.from_backend failed when T2 value is greater than 2 * T1, however, sometimes backend returns such T2 value. This change truncates T2 value up to 2 * T1 with issuing a user warning. Co-authored-by: Hiroshi Horii <horii@jp.ibm.com>
hhorii
added a commit
to hhorii/qiskit-aer
that referenced
this pull request
Mar 14, 2022
…#1467) * Change not to fail to run noisy simulation with T2 > 2 * T1 Previously NoiseModel.from_backend failed when T2 value is greater than 2 * T1, however, sometimes backend returns such T2 value. This change truncates T2 value up to 2 * T1 with issuing a user warning. Co-authored-by: Hiroshi Horii <horii@jp.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1464 by changing the behavior of
NoiseModel.from_backendwhen T2 value greater than 2 * T_1 is supplied such that it truncates the T2 value up to 2 * T_1 with issuing a user warning. Previously, thermal relaxation errors were created based on non-truncated T2 values, which was causing errors when running noise simulations as reported in #1464.